Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update futures version to remove dyn warning while building deno #3074

Closed
trivikr opened this issue Oct 6, 2019 · 4 comments
Closed

update futures version to remove dyn warning while building deno #3074

trivikr opened this issue Oct 6, 2019 · 4 comments

Comments

@trivikr
Copy link
Contributor

trivikr commented Oct 6, 2019

The following warning appears while trying to build deno with command cargo build -vv:

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/future/catch_unwind.rs:28:22
   |
28 |     type Error = Box<Any + Send>;
   |                      ^^^^^^^^^^ help: use `dyn`: `dyn Any + Send`
   |
   = note: #[warn(bare_trait_objects)] on by default

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/future/shared.rs:310:32
    |
310 |     fn cause(&self) -> Option<&error::Error> {
    |                                ^^^^^^^^^^^^ help: use `dyn`: `dyn error::Error`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/future/mod.rs:106:50
    |
106 |     pub type BoxFuture<T, E> = ::std::boxed::Box<Future<Item = T, Error = E> + Send>;
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Future<Item = T, Error = E> + Send`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/select.rs:37:40
   |
37 |             (&mut self.stream2 as &mut Stream<Item=_, Error=_>,
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item=_, Error=_>`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/select.rs:38:40
   |
38 |              &mut self.stream1 as &mut Stream<Item=_, Error=_>)
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item=_, Error=_>`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/select.rs:40:40
   |
40 |             (&mut self.stream1 as &mut Stream<Item=_, Error=_>,
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item=_, Error=_>`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/select.rs:41:40
   |
41 |              &mut self.stream2 as &mut Stream<Item=_, Error=_>)
   |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item=_, Error=_>`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/catch_unwind.rs:37:22
   |
37 |     type Error = Box<Any + Send>;
   |                      ^^^^^^^^^^ help: use `dyn`: `dyn Any + Send`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/futures_unordered.rs:602:50
    |
602 | unsafe fn hide_lt<T>(p: *mut ArcNode<T>) -> *mut UnsafeNotify {
    |                                                  ^^^^^^^^^^^^ help: use `dyn`: `dyn UnsafeNotify`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/futures_unordered.rs:603:30
    |
603 |     mem::transmute(p as *mut UnsafeNotify)
    |                              ^^^^^^^^^^^^ help: use `dyn`: `dyn UnsafeNotify`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/stream/mod.rs:132:50
    |
132 |     pub type BoxStream<T, E> = ::std::boxed::Box<Stream<Item = T, Error = E> + Send>;
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item = T, Error = E> + Send`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/sink/mod.rs:55:48
   |
55 |       pub type BoxSink<T, E> = ::std::boxed::Box<Sink<SinkItem = T, SinkError = E> +
   |  ________________________________________________^
56 | |                                                ::core::marker::Send>;
   | |___________________________________________________________________^
help: use `dyn`
   |
55 |     pub type BoxSink<T, E> = ::std::boxed::Box<dyn Sink<SinkItem = T, SinkError = E> +
56 |                                                ::core::marker::Send>;
   |

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/core.rs:21:12
   |
21 |     f: &'a Fn() -> NotifyHandle,
   |            ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn() -> NotifyHandle`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/core.rs:45:23
   |
45 |     pub fn new(f: &'a Fn() -> NotifyHandle, id: usize) -> BorrowedUnpark<'a> {
   |                       ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn() -> NotifyHandle`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/data.rs:35:41
   |
35 |                                     Box<Opaque>,
   |                                         ^^^^^^ help: use `dyn`: `dyn Opaque`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/data.rs:124:36
    |
124 |                 &**entry as *const Opaque as *const T
    |                                    ^^^^^^ help: use `dyn`: `dyn Opaque`

warning: trait objects without an explicit `dyn` are deprecated
  --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:93:17
   |
93 |     Old(&'a Arc<Unpark>),
   |                 ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:107:13
    |
107 |     Old(Arc<Unpark>),
    |             ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:121:23
    |
121 |     pub fn new(f: &'a Fn() -> NotifyHandle, id: usize) -> BorrowedUnpark<'a> {
    |                       ^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Fn() -> NotifyHandle`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:208:35
    |
208 |                 &**old1 as *const Unpark == &**old2 as *const Unpark
    |                                   ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:208:63
    |
208 |                 &**old1 as *const Unpark == &**old2 as *const Unpark
    |                                                               ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:222:47
    |
222 |     pub fn poll_future(&mut self, unpark: Arc<Unpark>) -> Poll<F::Item, F::Error> {
    |                                               ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:248:36
    |
248 |     pub fn execute(self, exec: Arc<Executor>)
    |                                    ^^^^^^^^ help: use `dyn`: `dyn Executor`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:269:47
    |
269 |     pub fn poll_stream(&mut self, unpark: Arc<Unpark>)
    |                                               ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:295:67
    |
295 |     pub fn start_send(&mut self, value: S::SinkItem, unpark: &Arc<Unpark>)
    |                                                                   ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:303:47
    |
303 |     pub fn poll_flush(&mut self, unpark: &Arc<Unpark>)
    |                                               ^^^^^^ help: use `dyn`: `dyn Unpark`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:402:22
    |
402 |     spawn: Spawn<Box<Future<Item = (), Error = ()> + Send>>,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Future<Item = (), Error = ()> + Send`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:409:15
    |
409 |     exec: Arc<Executor>,
    |               ^^^^^^^^ help: use `dyn`: `dyn Executor`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:598:14
    |
598 |     set: Arc<EventSet>,
    |              ^^^^^^^^ help: use `dyn`: `dyn EventSet`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/std/mod.rs:607:25
    |
607 |     pub fn new(set: Arc<EventSet>, id: usize) -> UnparkEvent {
    |                         ^^^^^^^^ help: use `dyn`: `dyn EventSet`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/mod.rs:634:17
    |
634 |     inner: *mut UnsafeNotify,
    |                 ^^^^^^^^^^^^ help: use `dyn`: `dyn UnsafeNotify`

warning: trait objects without an explicit `dyn` are deprecated
   --> /home/trivikr/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.29/src/task_impl/mod.rs:651:35
    |
651 |     pub unsafe fn new(inner: *mut UnsafeNotify) -> NotifyHandle {
    |                                   ^^^^^^^^^^^^ help: use `dyn`: `dyn UnsafeNotify`

These warnings seems to have been fixed upstream, so the version deno depends on needs to be updated

futures = "0.1.29"

@trivikr
Copy link
Contributor Author

trivikr commented Oct 6, 2019

0.1.29 is the latest stable version https://crates.io/crates/futures
The new version 0.3.0 is still in alpha https://github.com/rust-lang-nursery/futures-rs/releases

@trivikr
Copy link
Contributor Author

trivikr commented Oct 6, 2019

Documentation for 0.3.0-alpha https://docs.rs/futures-preview/0.3.0-alpha.19/futures/
The final 0.3.0 release is scheduled in conjunction with Rust 1.39 rust-lang/futures-rs#1893

@trivikr
Copy link
Contributor Author

trivikr commented Nov 6, 2019

futures 0.3.0 was released today https://github.com/rust-lang-nursery/futures-rs/releases/tag/0.3.0

@trivikr
Copy link
Contributor Author

trivikr commented Nov 17, 2019

Fixed by #3358

@trivikr trivikr closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant