Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): support multiple message listeners on MessagePort #23600

Merged
merged 1 commit into from Apr 30, 2024
Merged

fix(ext/node): support multiple message listeners on MessagePort #23600

merged 1 commit into from Apr 30, 2024

Conversation

satyarohith
Copy link
Member

Closes #23561

@satyarohith satyarohith enabled auto-merge (squash) April 29, 2024 11:50
littledivy
littledivy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyarohith satyarohith merged commit 0156f82 into main Apr 30, 2024
17 checks passed
@satyarohith satyarohith deleted the satya/fix_23561 branch April 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node:worker_threads] The behavior of MessagePort.on() differs between Deno and Node.js
2 participants
@satyarohith @littledivy