Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mode field of Deno.FileInfo on Windows #18053

Closed
lucacasonato opened this issue Mar 6, 2023 · 2 comments · Fixed by #18073
Closed

Implement mode field of Deno.FileInfo on Windows #18053

lucacasonato opened this issue Mar 6, 2023 · 2 comments · Fixed by #18073
Labels
bug Something isn't working node compat runtime Relates to code in the runtime crate windows Related to Windows platform

Comments

@lucacasonato
Copy link
Member

Right now the mode field is completely un-populated on Windows.

On Node, it is always 0 (libuv todo, hey @piscisaureus!)

On Go, it is reasonably populated. The mode very realistically emulates Unix. Code here

I think we should populate them like Go does.
@lucacasonato lucacasonato mentioned this issue Mar 6, 2023
Open
@lucacasonato
Copy link
Member Author

I'm running into some Node compat issues because of this. Can we populate it as 0 in node:fs for now also?

@lucacasonato lucacasonato added bug Something isn't working windows Related to Windows platform node compat runtime Relates to code in the runtime crate labels Mar 6, 2023
@piscisaureus
Copy link
Member

Yes let's do 0.

There is a tradeoff here - we can emulate unix more diligently but you end up making a lot more syscalls (slow!) and it's still probably not very useful.

@bartlomieju bartlomieju mentioned this issue Mar 8, 2023
Merged
bartlomieju added a commit that referenced this issue Mar 16, 2023
@bartlomieju @dsherret
feat(fs): support FileInfo.dev on Windows (#18073)
48a0b7f 
This commit adds support for retrieving `dev` information
when stating files on Windows.

Additionally `Deno.FileInfo` interfaces was changed to always
return 0 for fields that we don't retrieve information for on Windows.

Closes #18053

---------

Co-authored-by: David Sherret <dsherret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working node compat runtime Relates to code in the runtime crate windows Related to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fs): support FileInfo.dev on Windows bartlomieju/deno
2 participants
@piscisaureus @lucacasonato