Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stringer interface #746

Merged

Conversation

sushilkg
Copy link
Contributor

Fixes #745.

Caused by golang-sql/sqlexp@d42ba59.

@sushilkg sushilkg mentioned this pull request May 19, 2022
@sushilkg sushilkg force-pushed the patch/implement-stringer-on-error branch from d17c487 to 7a6467a Compare May 19, 2022 12:50
@sushilkg sushilkg marked this pull request as draft May 19, 2022 12:52
@sushilkg sushilkg force-pushed the patch/implement-stringer-on-error branch from 7a6467a to fc16a1d Compare May 19, 2022 12:53
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #746 (e5f6e8b) into master (e538731) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   71.29%   71.30%   +0.01%     
==========================================
  Files          24       24              
  Lines        5386     5388       +2     
==========================================
+ Hits         3840     3842       +2     
  Misses       1301     1301              
  Partials      245      245              
Impacted Files Coverage Δ
error.go 100.00% <100.00%> (ø)
token.go 64.21% <100.00%> (ø)
tds.go 65.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e538731...e5f6e8b. Read the comment docs.

@sushilkg sushilkg marked this pull request as ready for review May 19, 2022 13:47
@shueybubbles
Copy link
Contributor

Could you port this to the microsoft fork? github.com/microsoft/go-mssqldb

@kardianos kardianos merged commit 7bb1ded into denisenkom:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error
3 participants