Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with unsighted types #713

Merged
merged 4 commits into from Jan 20, 2022
Merged

Fix bug with unsighted types #713

merged 4 commits into from Jan 20, 2022

Conversation

NikitaDef
Copy link
Contributor

@NikitaDef NikitaDef commented Jan 2, 2022

Data type 0x26 has an invalid data length or metadata length.
#713

NikitaDef and others added 2 commits December 11, 2021 20:00
Data type 0x26 has an invalid data length or metadata length.
@NikitaDef NikitaDef mentioned this pull request Jan 2, 2022
@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #713 (d3c75bc) into master (5ec1570) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   71.10%   71.08%   -0.02%     
==========================================
  Files          24       24              
  Lines        5208     5208              
==========================================
- Hits         3703     3702       -1     
- Misses       1280     1281       +1     
  Partials      225      225              
Impacted Files Coverage Δ
tvp_go19.go 93.02% <100.00%> (ø)
token.go 61.85% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec1570...d3c75bc. Read the comment docs.

@NikitaDef
Copy link
Contributor Author

NikitaDef commented Jan 15, 2022

@kardianos I add support unsigned types with test, which I forgot to add.
Please review @saeedgeek that MR

@kardianos kardianos merged commit b979f7a into denisenkom:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants