Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #151 Wildcard route should not be blocked by Parametric with diff… #152

Merged
merged 2 commits into from May 18, 2020
Merged

fix #151 Wildcard route should not be blocked by Parametric with diff… #152

merged 2 commits into from May 18, 2020

Conversation

dylannil
Copy link
Contributor

demo at #151

mcollina
mcollina approved these changes May 17, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from delvedor May 17, 2020 11:18
@dylannil
Copy link
Contributor Author

Another problem found:

router.find('GET', 'https://localhost/a/b/c')
// eql
router.find('GET', '/c')
// expect
router.find('GET', '/a/b/c')

mcollina
mcollina approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes May 18, 2020
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@delvedor delvedor merged commit b7320d0 into delvedor:master May 18, 2020
delvedor pushed a commit that referenced this pull request May 18, 2020
@dylannil @delvedor
fix #151 Wildcard route should not be blocked by Parametric with diff… (
b4cb4f5 
#152)
@delvedor
Copy link
Owner

Landed in v3.0.1 and v2.2.3 🎉

@dependabot dependabot bot mentioned this pull request Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dylannil @delvedor @mcollina