Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No match path param with ignoreTrailingSlash #146

Merged
merged 5 commits into from Mar 7, 2020
Merged

No match path param with ignoreTrailingSlash #146

merged 5 commits into from Mar 7, 2020

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Feb 21, 2020

Fixes #145

Still working on it

mcollina
mcollina reviewed Feb 21, 2020
View reviewed changes
test/issue-145.test.js Outdated Show resolved Hide resolved
@Eomm Eomm marked this pull request as ready for review February 22, 2020 21:15
mcollina
mcollina approved these changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes Mar 7, 2020
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the bugfix label Mar 7, 2020
@delvedor delvedor merged commit 275f03f into delvedor:master Mar 7, 2020
@Eomm Eomm mentioned this pull request May 6, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No match when ignoreTrailingSlash is set to true
3 participants
@Eomm @mcollina @delvedor