Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prettyPrint indent #130

Merged
merged 2 commits into from
Aug 30, 2019
Merged

fix prettyPrint indent #130

merged 2 commits into from
Aug 30, 2019

Conversation

fralonra
Copy link
Contributor

fix #129

It outputs the following:
5P10B82%$6S$32QNT @61SY

@mcollina
Copy link
Collaborator

Would you mind adding a unit test? https://github.com/delvedor/find-my-way/blob/master/test/pretty-print.test.js

delvedor
delvedor reviewed Aug 19, 2019
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the fix!
It looks ok to me, but as said by @mcollina, can you also add a unit test?

@fralonra
Copy link
Contributor Author

A unit test has been added!

mcollina
mcollina approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Aug 30, 2019
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit ec2c40e into delvedor:master Aug 30, 2019
@fralonra fralonra deleted the patch-1 branch August 30, 2019 12:07
@dependabot dependabot bot mentioned this pull request Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prettyPrint outputs wrong indent
3 participants
@fralonra @mcollina @delvedor