Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyO3 clippy workaround once 0.17 is release #757

Closed
tsh56 opened this issue Aug 21, 2022 · 1 comment · Fixed by #814
Closed

Remove PyO3 clippy workaround once 0.17 is release #757

tsh56 opened this issue Aug 21, 2022 · 1 comment · Fixed by #814
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tsh56
Copy link
Contributor

tsh56 commented Aug 21, 2022

Environment

Delta-rs version:
main branch

Binding:
Python

Environment:

  • Cloud provider: NA
  • OS: linux
  • Other: NA

Bug

What happened: A clippy inner attribute was added to work around a lint error that comes from the PyO3 project in conjunction with the Rust 1.63.0 release.

What you expected to happen: The project should build without lint checks disabled.

How to reproduce it: N/A

More details: The PyO3 ticket is expected to be resolved Tuesday 2022-08-23 with the 0.17 Release.

Fix: The following line should be removed, and the build is expected to succeed.

@tsh56 tsh56 added the bug Something isn't working label Aug 21, 2022
@houqp houqp added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 22, 2022
@tsh56
Copy link
Contributor Author

tsh56 commented Aug 30, 2022

Arrow just updated their version of pyo3 to 0.17, and that change is still awaiting release. In the meantime that is preventing cargo update from succeeding. Hopefully that fix will get released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants