Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt ruff for python linting in CI/CD #1149

Closed
roeap opened this issue Feb 15, 2023 · 3 comments · Fixed by #1158
Closed

Adopt ruff for python linting in CI/CD #1149

roeap opened this issue Feb 15, 2023 · 3 comments · Fixed by #1158
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@roeap
Copy link
Collaborator

roeap commented Feb 15, 2023

Description

As proud members of the Rust community, as well as advocates of rust backed python, I thought we could adopt ruff as our main python linter in CI/CD.

Its not a huge pain right now, but the change is also quite minimal in terms of effort, and I personally made great experiences with it several projects.

As a bonus we could add delta-rs to the list of adopters alongside many other great projects like, pydantic, polars, pandas and many more...

Use Case

Related Issue(s)

@roeap roeap added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 15, 2023
@houqp
Copy link
Member

houqp commented Feb 17, 2023

Yeah, I have been thinking of adding switching to ruff as well!

@fvaleye
Copy link
Collaborator

fvaleye commented Feb 17, 2023

Good idea 👍

wjones127 pushed a commit that referenced this issue Feb 22, 2023
# Description
This PR sets up ruff for python linting. It also enables isort from
within ruff and removes the standalone isort.

# Related Issue(s)
closes #1149

---------

Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@marijncv
Copy link
Contributor

For reference, I created a PR on the ruff repository to add delta-rs to the list of users

chitralverma pushed a commit to chitralverma/delta-rs that referenced this issue Mar 17, 2023
# Description
This PR sets up ruff for python linting. It also enables isort from
within ruff and removes the standalone isort.

# Related Issue(s)
closes delta-io#1149

---------

Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants