Bring conditions back to start with pry-byebug #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AliSepehri This seems to also be happening with pry-byebug 3.9.0 for me, so maybe it's something else. Are you sure this fixes the issue you are seeing? |
|
@deivid-rodriguez In my case, this resolves the issue. Could you try it out? |
|
This also resolves the issue for me as well. |
|
I just tried it out and it resolves the issue, indeed! So I'll just merge and release it! |
|
@deivid-rodriguez Sure! |
AliSepehri
force-pushed
the
fix-rails-console
branch
from
2aa2362
to
8551154
Compare
AliSepehri
force-pushed
the
fix-rails-console
branch
from
8551154
to
7910609
Compare
|
@deivid-rodriguez Is it normal that CI takes a lot? |
deivid-rodriguez
force-pushed
the
fix-rails-console
branch
from
7910609
to
702264f
Compare
|
Since it's your first contribution, I need to manually approve CI runs. Anyways, I amended your commit and will be merging this after CI. |
|
Thank you ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version breaks rails-console and it triggers debugger REPL instead of standard Pry REPL.
Fixes #391