Fix crash on TAB under ruby 2.7 #657
Conversation
terceiro
force-pushed
the
fix-crash-on-ruby-2.7
branch
from
07d4e9b
to
4e9f1b6
Compare
|
Thanks for this @terceiro. Hope to merge and release soon. |
|
@terceiro Could you rebase this PR and add a changelog entry? Hopefully the CI is fixed now. |
|
Also, I'd like to get this tested but it doesn't sound too easy. I'll give it a quick look and if I can't find an easy way I'll just ship it without tests. Of course, feel free to also try to figure out yourself too if you'd like to :) |
terceiro
force-pushed
the
fix-crash-on-ruby-2.7
branch
from
4e9f1b6
to
5c14f16
Compare
|
@deivid-rodriguez updated; sorry I can't think of a way of testing this cleanly |
|
I don't know what's the issue with the CI |
|
Weird, I'll have a look! |
deivid-rodriguez
force-pushed
the
fix-crash-on-ruby-2.7
branch
2 times, most recently
from
c6fdcfc
to
092a4b1
Compare
|
@terceiro I rebased this PR to trigger the CI and there's some issues on Windows that I believe are related to this changeset :(. I'll try to figure it out. |
deivid-rodriguez
force-pushed
the
fix-crash-on-ruby-2.7
branch
2 times, most recently
from
4b99423
to
f4e0f4b
Compare
When IRB from ruby 2.7 is loaded, it installs a Readline completion proc that assumes IRB is running (and crashes otherwise). Workaround this by clearing the Readline completion when using it directly.
deivid-rodriguez
force-pushed
the
fix-crash-on-ruby-2.7
branch
from
e0d6035
to
3de63dd
Compare
|
I added a test and a few tweaks. I also added a workaround for the Windows CI. I don't think it really fixes the problem there, but it will will only affect a very limited subset of Windows users (only those using a version of ruby on Windows older than the latest patch levels, and using a custom readline completion proc). I'll wait for reports of those and leave it as it is now. Thanks for fixing this @terceiro, I'll release this ASAP. |
|
11.1.2 is out! |
|
@deivid-rodriguez thanks for looking it!
|
Update ruby-byebug to 11.1.3. ## [11.1.3] - 2020-04-23 ### Fixed * [#674](deivid-rodriguez/byebug#674): crash when using byebug on ruby 2.7.0 on Windows. ## [11.1.2] - 2020-04-17 ### Fixed * [#657](deivid-rodriguez/byebug#657): crash when hitting \<TAB\> due to IRB completion mechanism included in the default ruby 2.7 version of the `irb` gem ([@terceiro]).
When IRB from ruby 2.7 is loaded, it installs a Readline completion proc
that assumes IRB is running (and crashes otherwise). Workaround this by
clearing the Readline completion when using it directly.
Fixes #654