-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't works with React Native (Expo) With Hermes #595
Comments
Hi, I'll try to take a look, can you share a message that references deepstream explicitly? That error doesn't... |
It doesn't, just try to import the SDK (installed with the REACT_NATIVE env var) somewhere and you end up with this… :'( |
Ok, found a few bugs, solved in lateste release v7.0.1 These are my steps using expo:
it works as expected |
Please reopen with detailed steps to reproduce if the problem persists |
Looks like it's not working in my project still, I'll check deeper but we have an issue I guess. About the installation on React NativeAlso, I've some concerns about the technique of doing the install using an env variable. As far as I can see, this will run a post-install script that changes code in the node_modules. With this technique this work on the computer that initially did the installation. But coworkers that pull your changes on git just end up with the "standard" version. I guess it would be better to add some checks in the code to check whether or not we are in react native environment. See facebook/react-native@3c65e62 @jaime-ez what do you think ? PS : I'll give detailed reproduction soon |
Hi, take a look at the original issue #534 for some background. An option you can take is that in your own project's package.json add a postinstall script:
That way anyone who clones your repo will have the desired version |
closing due to inactivity, please provide more information if the problem persists |
Hi,
Just wanted to share that the Client SDK no longer works with react native and expo.
Expo version : "expo": "~47.0.12",
The text was updated successfully, but these errors were encountered: