Ft/handle external pkg name in response #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masu-mi
force-pushed
the
ft/handle-external-pkg-name-in-response
branch
from
61fe90a
to
6a55f6f
Compare
generate ./... And update user code * ./internal/test/strict-server/chi/server.go * ./internal/test/strict-server/gin/server.go * ./internal/test/strict-server/echo/server.go
masu-mi
force-pushed
the
ft/handle-external-pkg-name-in-response
branch
2 times, most recently
from
d577028
to
d682e20
Compare
|
I would like to note that this caused a break in a pattern I had been using in a pre-release. Specifically, before this change, it was possible to return the type that was being referenced directly, but now that its embedded, It needs to be wrapped. (or a var created and the individual fields set.) IE I have to return a I feel like neither solution is perfect tho as making common code for the struct server may just be limited by go's type system/may need to be revisited after generic methods/type switches. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* feat: add test case issue-removed-external-ref
* chore: go generate
* feat: fix broken pkg name
* fix: broken generated code of strict-interface.tmpl for external schema
* fix: broken strict-interface.tmpl
* Update generated code
generate ./...
And update user code
* ./internal/test/strict-server/chi/server.go
* ./internal/test/strict-server/gin/server.go
* ./internal/test/strict-server/echo/server.go
Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
an example resolving of #751
changes
internal/test/issues/issue-removed-external-refUppercaseFirstCharacterWithPkgNamefunction forucFirstWithPkgNamefilterucFirstWithPkgNamefilter instead ofucFirstfilter in template