Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last release was a breaking change, should it have not been a v2 release? #629

Closed
matyat opened this issue Jun 14, 2022 · 1 comment · Fixed by #747
Closed

Last release was a breaking change, should it have not been a v2 release? #629

matyat opened this issue Jun 14, 2022 · 1 comment · Fixed by #747

Comments

@matyat
Copy link

matyat commented Jun 14, 2022

The latest release has changed the cli and is now incompatible with previous invocations. It's an easy fix by adding the --old-config-style, but users shouldn't have to do that for a minor release.

@deefdragon
Copy link
Contributor

As I said in #630, it took me much longer than it should to figure out why my config and CI/CD pipeline was broken. This REALLY should be a V2. Please release a revert as v1.12 so that updates pull the old format (including a deprecation warning would be best), and THEN push the new changes as a separate v2 module.

jamietanna pushed a commit to jamietanna/oapi-codegen that referenced this issue Jul 29, 2022
As a means to avoid the breaking changes we introduced in v1.11.0, where
the new-style configuration was made the default, we can tweak our
heuristic for how we work out what configuration is in use by only using
the new-style config if the new `--config` flag is used.

This change in itself is non-breaking, and makes it possible to continue
using the old configuration arguments, as long as you don't provide the
new `--config` flag.

Similar to thoughts in deepmap#629, but does not require a revert.

Closes deepmap#629.
deepmap-marcinr pushed a commit that referenced this issue Sep 8, 2022
Release v1.11.0 introduced a new config file format, and it's
default-on, which breaks existing generation upon update. This change
attempts to infer the version of the config file and flags from the
the structure of the file, or the presence of deprecated flags.

Closes #629
deepmap-marcinr added a commit that referenced this issue Sep 8, 2022
Release v1.11.0 introduced a new config file format, and it's
default-on, which breaks existing generation upon update. This change
attempts to infer the version of the config file and flags from the
the structure of the file, or the presence of deprecated flags.

Closes #629

Co-authored-by: marcinromaszewicz <marcinromaszewicz@deepmap.ai>
adrianpk pushed a commit to foorester/oapi-codegen that referenced this issue Jan 16, 2024
Release v1.11.0 introduced a new config file format, and it's
default-on, which breaks existing generation upon update. This change
attempts to infer the version of the config file and flags from the
the structure of the file, or the presence of deprecated flags.

Closes deepmap#629

Co-authored-by: marcinromaszewicz <marcinromaszewicz@deepmap.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants