Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSZip #1080

Closed
mofojed opened this issue Feb 9, 2023 · 2 comments · Fixed by #1457
Closed

Update JSZip #1080

mofojed opened this issue Feb 9, 2023 · 2 comments · Fixed by #1457
Labels
enhancement New feature or request
Milestone
August 2023

Comments

@mofojed
Copy link
Member

mofojed commented Feb 9, 2023

We are pinned to 3.2.2 of JSZip that has nodestream support, as it was removed: Stuk/jszip#663

Making a ticket to update the version and track this issue. Previously Dependabot opened a PR: #183
@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels Feb 9, 2023
@mofojed
Copy link
Member Author

mofojed commented Feb 9, 2023

Tried updating to latest v3.10.1, still failing with error:

[CsvInputBar] Error: nodestream is not supported by this platform
    at a.checkSupport (jszip.min.js:13:34660)
    at f.toNodejsStream (jszip.min.js:13:27913)
    at n.nodeStream (jszip.min.js:13:45595)
    at CsvTypeParser.parse (CsvTypeParser.ts:221:36)
    at _CsvParser.parse (CsvParser.ts:192:16)
    at CsvInputBar.handleFile (CsvInputBar.tsx:220:12)
    at CsvInputBar.tsx:245:18

@mattrunyon
Copy link
Collaborator

Should we be using nodestream even? It might be the older stream type where they bundled the Node built-in into the browser, but browsers have been making progress on having native streams

@vbabich vbabich added this to the March 2023 milestone Feb 15, 2023
@vbabich vbabich removed the triage Issue requires triage label Feb 15, 2023
@mofojed mofojed modified the milestones: March 2023, April 2023 Apr 3, 2023
@mofojed mofojed modified the milestones: April 2023, June 2023 Jun 13, 2023
@mofojed mofojed modified the milestones: June 2023, July 2023 Jun 28, 2023
@mofojed mofojed mentioned this issue Aug 4, 2023
Closed
@mattrunyon mattrunyon mentioned this issue Aug 23, 2023
Merged
@mofojed mofojed modified the milestones: July 2023, August 2023 Aug 28, 2023
mofojed pushed a commit that referenced this issue Aug 31, 2023
@mattrunyon
fix: Zip CSV uploads not working (#1457)
08d0296 
Fixes #1080. Fixes #1416 

Updates jszip and uses the internal stream helper instead of nodestream
which we would need a polyfill for. The progress on zip uploads is a bit
odd since we use the unzip progress. It seems papaparse loads more from
the stream while processing/before processing and can finish reading the
zip before it's done processing chunks.

Also, uploading the tables seems to be a blocking operation. Not sure if
that's an easy fix, but after the 50% mark on uploading a large zip,
there are some blocks on the main thread (marching ants freezes as an
indicator).

There is a ~2GB limit for JSZip it seems
Stuk/jszip#777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

fix: Zip CSV uploads not working mattrunyon/web-client-ui
3 participants
@vbabich @mofojed @mattrunyon