Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Explicit and Distinct DeepgramHttpClientOptions and DeepgramWsClientOptions #379

Open
dvonthenen opened this issue Apr 24, 2024 · 0 comments

Comments

@dvonthenen
Copy link
Contributor

Proposed changes

Currently, all WebSockets and HTTP(s) options are combined into a single ClientOptions class. You run into situations when options like KeepAlive, which are used for WebSockets, are needed. You can enable KeepAlive on HTTP(s) clients like ManageClient, but they literally have no function or meaning.

The more the WS and HTTP(s) options grow, the more this object will have options that mean something for one transport type but will have no meaning in the other.

This requires implementing or should I say removing this issue:
#378

Context

Possible Implementation

Other information

@dvonthenen dvonthenen added this to the Python SDK 4.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@dvonthenen and others