core: Update balance for only existing assets on tip change #2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2757
I was able to reproduce and debug the issue. The problem was that
asset.TipChangeNote
notification might be received bycore
before the wallet exists.There are just two such notifications
asset.TipChangeNote
andasset.BalanceChangeNote
and we already check for an existing wallet forasset.BalanceChangeNote
before proceeding.@JoeGruffins please confirm if you can still reproduce with this PR. I got a log when debugging the issue.