New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate and implement _rent optimization were verify unsafe transfer can be removed #83

Open

fzavalia opened this issue Oct 20, 2022 · 0 comments

Collaborator

fzavalia commented Oct 20, 2022

The optimization can be found in this branch https://github.com/decentraland/rentals-contract/tree/feat/audit-xc-remove-verify-unsafe-transfer

acceptListing and acceptOffer save ~5k with this change. However, accepting an offer through safeTransfer costs ~4k more.

Keeping track of it in this issue it case we need to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment