Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General millisecond diff #526

Closed
DiegoRBaquero opened this issue Dec 3, 2017 · 4 comments
Closed

General millisecond diff #526

DiegoRBaquero opened this issue Dec 3, 2017 · 4 comments
Labels
discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement

Comments

@DiegoRBaquero
Copy link
Contributor

Hey guys,

Is there any way to get a general non-namespaced millisecond diff?

It would be great to see if anything is blocking the event loop. And which things take long.

@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

Could you expand a bit on what you mean here?

@DiegoRBaquero
Copy link
Contributor Author

Each name space has it's own millisecond diff. So you see +10s inmediately after a +1ms sometimes because that namespace hadn't been called in +10s and there's no way to know how much time it took since last logged debug call, which should be +1ms or something like that.

image

if these are subsequent, it should be +10s for first and +1ms for the second.

See #528 where I provide a fix.

@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

I agree that this would be useful to certain users but not as a blanket case as namespaced diffs are vitally important to many people.

Check #582 for a potential solution.

I'll leave this open until a better solution is put in place.

@Qix- Qix- added discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement labels Jun 20, 2018
@Qix-
Copy link
Member

Qix- commented Dec 18, 2018

Closing in favor of #582.

@Qix- Qix- closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement
Development

No branches or pull requests

2 participants