Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide tty date #486

Closed
wants to merge 4 commits into from
Closed

Hide tty date #486

wants to merge 4 commits into from

Conversation

amejiarosario
Copy link

@amejiarosario amejiarosario commented Aug 12, 2017 •
edited

This option is very needed when running Node on systems that already provides time stamps such as Heroku, PM2, systemd...

Solves #453

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.585% when pulling 428a07a on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@coveralls
Copy link

coveralls commented Aug 12, 2017 •
edited

Coverage Status

Coverage increased (+1.3%) to 74.051% when pulling 62589c0 on amejiarosario:hide-tty-date into 13e1d06 on visionmedia:master.

@ptusch
Copy link

ptusch commented Sep 5, 2017 •
edited

Bump Would really love this feature as debug poisons our logs for now :s

Qix-
Qix- approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - want to make sure the other maintainers agree on adding yet another environment variable. I don't see a reason not to in this case.

@amejiarosario
Copy link
Author

amejiarosario commented Sep 5, 2017 •
edited

Thanks! yes, as mentioned before, this env var is very needed for avoiding the double timestamps in Heroku, PM2, Systemd...

TooTallNate added a commit that referenced this pull request Sep 22, 2017
@TooTallNate
Add DEBUG_HIDE_TTY_DATE env var (#486)
56a3853 
Squashed commit of the following:

commit 62589c0
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:24:45 2017 -0400

    solves merge conflict

commit 55e5c5e
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:21:16 2017 -0400

    docs

commit e09dec3
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:19:10 2017 -0400

    cleanup

commit 9dd6a2b
Author: Adrian Mejia <admejiar@cisco.com>
Date:   Sat Aug 12 15:05:53 2017 -0400

    enables DEBUG_HIDE_TTY_DATE
@TooTallNate
Copy link
Contributor

Thank you! Merged in 56a3853.

@amejiarosario amejiarosario deleted the hide-tty-date branch September 22, 2017 18:35
@amejiarosario amejiarosario restored the hide-tty-date branch September 22, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qix- Qix- Qix- approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amejiarosario @coveralls @ptusch @TooTallNate @Qix-