Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window is not defined #461

Closed
marbemac opened this issue May 18, 2017 · 1 comment
Closed

window is not defined #461

marbemac opened this issue May 18, 2017 · 1 comment

Comments

@marbemac
Copy link
Contributor

A recent change (linked below) removed undefined checks on a variety of globals. This causes exceptions in certain environments, for example web workers. If debug is included in a library used in a web worker, it will fail, since web workers do not have global window objects.

I would propose just adding the undefined checks back to the start of the if statements in the code linked below.

cae07b7

@marbemac
Copy link
Contributor Author

Ok I just went ahead and create a quick little PR: #462. Moving conversation over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant