Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suddenly stopped working on Node.js 0.6 #450

Closed
dougwilson opened this issue Apr 30, 2017 · 5 comments
Closed

Suddenly stopped working on Node.js 0.6 #450

dougwilson opened this issue Apr 30, 2017 · 5 comments

Comments

@dougwilson
Copy link
Contributor

Up to version 2.3.3 this module worked fine in Node.js 0.6, but now it no longer does. I'm not sure if this is an issue or not, because there is nothing in the docs or even package.json that indicated what versions of Node.js are actually the supported versions.

  1. Is this an issue that Node.js 0.6 stopped working?
  2. What are the versions of Node.js that are supported?
  3. Can the version range be at least added to engines.node in package.json?
@TooTallNate
Copy link
Contributor

  1. We should probably fix whatever broke.
  2. Virtually every node version IMO.
  3. Fine by me, but perhaps kind of redundant if the goal is "node": "*".

@calidion
Copy link

it is most probably a problem caused by npm, where the range versions always break packages..

@dougwilson
Copy link
Contributor Author

Thanks for the clarification, @TooTallNate ! I'm happy to make a PR with a suggested fix, just wanted to check if you even cared about the version first before bothering :) I agree that adding "node": "*" would be redundant. It sounds to me like there is no official minimum version right now, rather leaving it up to the "market" to decide (by users making PRs with suggested fixes).

So the issue is just that util._extend doesn't exist in Node.js 0.6 (plus, it is an underscore-prefixed function, so... shrugs). Anyway, without going through the complications of trying to introduce a dependency, The smallest portion of _extend was just inlined in PR #452

@dougwilson
Copy link
Contributor Author

Looks like the PR is merged now 🎊 ping me on the next npm publish whenever you get to it 😄

@TooTallNate
Copy link
Contributor

Published in 2.6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants