Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.env.DEBUG still ignored in Electron #439

Closed
blahah opened this issue Apr 9, 2017 · 5 comments
Closed

process.env.DEBUG still ignored in Electron #439

blahah opened this issue Apr 9, 2017 · 5 comments

Comments

@blahah
Copy link

blahah commented Apr 9, 2017

Even with v2.6.3, after #431 was merged, debug still ignores the DEBUG env var in electron. I have to manually transfer the env var to localstorage to make it work:

localStorage.setItem('debug', process.env.DEBUG)
@thebigredgeek
Copy link
Contributor

Hmm. paging @paulcbetts, any idea here? I would have thought #431 should have fixed this?

@blahah
Copy link
Author

blahah commented Apr 10, 2017

Sorry I didn't provide more info before - was racing to a deadline. I'll take a deeper look now and see if I can suggest / PR a solution

@anaisbetts
Copy link
Contributor

anaisbetts commented Apr 13, 2017

Dunno, this works for me in v2.6.3 - do you have node-integration enabled? Also, one troll thing that happens is that, because so many people use visionmedia/debug, it is entirely possible that someone has loaded an earlier version in a module, which now is overriding your current version.

@blahah
Copy link
Author

blahah commented Apr 13, 2017

@paulcbetts yeah I think the latter may have been happening. I now can't recreate the bug. What is always happening is that whatever I set as DEBUG= gets auto-transferred to localStorage, but not by my code. I'll keep an eye out, but I think this can be closed for now.

Thanks all :)

@thebigredgeek
Copy link
Contributor

Yay Javascript! I wonder how often people end up running 20+ versions of debug on their server hahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants