Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Type Error coming from browser.js #436

Closed
Camyll opened this issue Mar 27, 2017 · 9 comments
Closed

Uncaught Type Error coming from browser.js #436

Camyll opened this issue Mar 27, 2017 · 9 comments
Labels
bug This issue identifies a malfunction has-pr This issue has an accompanying pull request

Comments

@Camyll
Copy link

Camyll commented Mar 27, 2017

TypeError: Cannot read property 'style' of null happening when document.documentElement is null because there is no null check. Would like to put in a PR to fix it if you guys decide not to.

@thebigredgeek
Copy link
Contributor

Yup, feel free to submit a PR :)

@thebigredgeek
Copy link
Contributor

@Camyll are you down to help us with a PR?

@Camyll
Copy link
Author

Camyll commented Apr 6, 2017

@thebigredgeek sure I can probably get to it by the end of the week. It's just a simple null check for document.documentElement that needs to be added. Checking if it's undefined is not enough

@thebigredgeek
Copy link
Contributor

We could just check a boolean cast. That would be the most error proof. Seems like this kind of stuff continues to creep up

@Camyll
Copy link
Author

Camyll commented Apr 14, 2017

@thebigredgeek yeah just let me know if you guys want to make the change, if not I can try and get to it soon. Sorry I keep forgetting

@fourpixels
Copy link

@thebigredgeek @Camyll any info on that?

@thebigredgeek
Copy link
Contributor

#447 <- just waiting on a sanity check

@fourpixels
Copy link

Great, thanks!

@Qix- Qix- added bug This issue identifies a malfunction has-pr This issue has an accompanying pull request labels Jun 20, 2018
@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

Looks like #447 was merged. Please let me know if it didn't solve the problem.

@Qix- Qix- closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue identifies a malfunction has-pr This issue has an accompanying pull request
Development

No branches or pull requests

4 participants