Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.env.DEBUG ignored in Electron apps for all cases #431

Merged

Conversation

anaisbetts
Copy link
Contributor

This PR fixes the code introduced in #331 that breaks the Electron case, but also prioritizes LocalStorage if present

@anaisbetts anaisbetts changed the title LocalStorage returns undefined for any key not present process.env.DEBUG ignored in Electron apps for all cases Mar 3, 2017
@coveralls
Copy link

coveralls commented Mar 3, 2017

Coverage Status

Coverage remained the same at 63.75% when pulling 8bba00d on paulcbetts:undefined-is-not-a-debug-value into 23bc780 on visionmedia:master.

anaisbetts added a commit to anaisbetts/trickline that referenced this pull request Mar 3, 2017
@anaisbetts
Copy link
Contributor Author

Paging @thebigredgeek to the white courtesy phone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants