Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap #191

Open
doebi opened this issue Oct 15, 2022 · 1 comment
Open

Bootstrap #191

doebi opened this issue Oct 15, 2022 · 1 comment

Comments

@doebi
Copy link

doebi commented Oct 15, 2022

In case you were wondering why the Dropdown Menu was not aligning properly on the Navigation bar: Your bootstrap setup is kinda weird.

According to your package.json you are using bootstrap 5.2-beta1 and react-bootstrap 1.4.3.

    "bootstrap": "5.2.0-beta1",
    "react-bootstrap": "^1.4.3",

These versions are incompatible.

react-bootstrap 1.x is for bootstrap 4.x
react-bootstrap 2.x is for bootstrap 5.x

Please change your bootstrap version accordingly.

diff --git a/ui/package.json b/ui/package.json
index de5c4a6..e38a678 100644
--- a/ui/package.json
+++ b/ui/package.json
@@ -5,10 +5,10 @@
   "private": true,
   "dependencies": {
     "autoprefixer": "10.4.5",
-    "bootstrap": "5.2.0-beta1",
+    "bootstrap": "^5.2.0",
     "jwt-decode": "^3.1.2",
     "react": "^17.0.1",
-    "react-bootstrap": "^1.4.3",
+    "react-bootstrap": "^2.5.0",
     "react-dom": "^17.0.1",
     "react-dropzone": "^11.3.2",
     "react-dropzone-uploader": "^2.11.0",

I started to fix this along with some other related issues on this branch: https://github.com/doebi/rmfakecloud/tree/dev
These changes are untested and not ready for merge.

While I was eager to apply some fixes and improvements, the quality of this codebase is questionable and not a good base for further changes.

@ddvk
Copy link
Owner

ddvk commented Oct 16, 2022

the ui was a quick hack, there is a pull request for a new ui...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants