Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.UserHomeDir() instead of go-homedir #3084

Closed
rfay opened this issue Jul 2, 2021 · 0 comments
Closed

Use os.UserHomeDir() instead of go-homedir #3084

rfay opened this issue Jul 2, 2021 · 0 comments
Milestone
v1.19

Comments

@rfay
Copy link
Member

rfay commented Jul 2, 2021

golang v1.12+ has os.UserHomeDir(), so we should be using that instead of importing https://github.com/mitchellh/go-homedir

I learned about this in spf13/cobra#853
@rfay rfay added this to the v1.19 milestone Sep 10, 2021
rfay added a commit to rfay/ddev that referenced this issue Oct 16, 2021
@rfay
Change to use os.UserHomeDir(), fixes ddev#3084
06864e8 
There is one use of mitchellh/gohomedir that remains
I don't think any new go feature expands ~
@rfay rfay mentioned this issue Oct 16, 2021
Merged
@rfay rfay closed this as completed in 42adca2 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.19
Development

No branches or pull requests
1 participant
@rfay