-
Notifications
You must be signed in to change notification settings - Fork 1.7k
consolidate timestamp logic #5979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
…labs/dbt-core into consolidate_timestamp_logic
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
…labs/dbt-core into consolidate_timestamp_logic
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
dbeatty10
approved these changes
Sep 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Consolidate date macros into dates.sql * rename to timestamps.sql * fix whitespace + add changie * cleanup macros and add testing * fix whitespace * remove now macro * fix functional test * remove local config * make snowflake backwards compat return utc * move timestamps to adaptor base tests * move backcompat macros to respective adapters * change timestamp param to source_timestamp * move timestamps.py to utils * update changie.yaml * make expected schema a fixture * formatting * add debug message to assert * fix changie.yaml * Update tests/adapter/dbt/tests/adapter/utils/test_timestamps.py Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Update plugins/postgres/dbt/include/postgres/macros/timestamps.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Update .changie.yaml * add backcompat utc * remove current_timestamp_in_utc * remove convert_timezone * add _in_utc_backcompat * fix macro_calls typo * add expected sql validation to test_timestamps * make expected_sql optional * improve sql check string comparison test * remove extraneous test file * add timestamp casting back * Update plugins/postgres/dbt/include/postgres/macros/adapters.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * add check_relation_has_expected_schema to comments * fix whitespace * remove default impl of current_timestamp * manual changie log fix Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> (cherry picked from commit 50fe25d)
leahwicz
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Consolidate date macros into dates.sql * rename to timestamps.sql * fix whitespace + add changie * cleanup macros and add testing * fix whitespace * remove now macro * fix functional test * remove local config * make snowflake backwards compat return utc * move timestamps to adaptor base tests * move backcompat macros to respective adapters * change timestamp param to source_timestamp * move timestamps.py to utils * update changie.yaml * make expected schema a fixture * formatting * add debug message to assert * fix changie.yaml * Update tests/adapter/dbt/tests/adapter/utils/test_timestamps.py Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Update plugins/postgres/dbt/include/postgres/macros/timestamps.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Update .changie.yaml * add backcompat utc * remove current_timestamp_in_utc * remove convert_timezone * add _in_utc_backcompat * fix macro_calls typo * add expected sql validation to test_timestamps * make expected_sql optional * improve sql check string comparison test * remove extraneous test file * add timestamp casting back * Update plugins/postgres/dbt/include/postgres/macros/adapters.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * add check_relation_has_expected_schema to comments * fix whitespace * remove default impl of current_timestamp * manual changie log fix Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> (cherry picked from commit 50fe25d) Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
changie new
to create a changelog entry