Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Mac - Horizontal scrolling not working #686

Open
saeedvaziry opened this issue Jan 7, 2024 · 2 comments · May be fixed by #689
Open

BUG: Mac - Horizontal scrolling not working #686

saeedvaziry opened this issue Jan 7, 2024 · 2 comments · May be fixed by #689
Labels
bug Something isn't working Waiting for feedback More information from users needed

Comments

@saeedvaziry
Copy link

Describe the bug

Horizontal scrolling using shift + scroll not working on the data view.

To Reproduce
Open a table with more columns that needs to be scrolled horizontally.

Version Information (please complete the following information):

  • OS: Mac
  • App Version: 5.2.7
  • Install source:installer
  • Type - Application
  • Database engine: MySQL
@ProjectInfinity
Copy link
Collaborator

I can confirm that it works under Windows, Linux and Web. Can any more Mac users confirm?

@ProjectInfinity ProjectInfinity added Waiting for feedback More information from users needed bug Something isn't working labels Jan 9, 2024
@ProjectInfinity ProjectInfinity changed the title BUG: Horizontal scrolling not working BUG: Mac - Horizontal scrolling not working Jan 9, 2024
@KKishikawa
Copy link
Contributor

I have confirmed that correctly worked on Windows, but this bug occurred on MacOS (both Electron App and Web).

It seems that this bug happens on packages/web/src/datagrid/DataGridCore.svelte.

dbgate/packages/web/src/datagrid/DataGridCore.svelte

Lines 1273 to 1280 in 3e8dabc

function handleGridWheel(event) {
if (event.shiftKey) {
scrollHorizontal(event.deltaY, event.deltaX);
} else {
scrollHorizontal(event.deltaX, event.deltaY);
scrollVertical(event.deltaX, event.deltaY);
}
}

I have confirmed that the processing branch of the handleGridWheel function by the shift key works on MacOS.
The scrollHorizontal function may be the cause.

@ProjectInfinity
I will try to fix it this weekend.

@KKishikawa KKishikawa linked a pull request Jan 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Waiting for feedback More information from users needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Mac): horizontal scrolling when shift key is held KKishikawa/dbgate
3 participants
@ProjectInfinity @KKishikawa @saeedvaziry