Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging refactor #589

Open
Tpuljak opened this issue May 21, 2024 · 0 comments
Open

Logging refactor #589

Tpuljak opened this issue May 21, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Tpuljak
Copy link
Member

Tpuljak commented May 21, 2024

Is your feature request related to a problem? Please describe.
Workspace and project logs are written to from multiple sources (Daytona, Providers, etc.). This leads to issues on how to display certain logs because the CLI does not differentiate between, for example, pull progress, push progress, state messages, workspace or project logs, etc.

Describe the solution you'd like
We should look to how Docker (and similar tools) handle progress messages. Docker streams "events" to the CLI and the CLI then decides on how to display the message based on the terminal size. Having log entries as JSON object would also make it easier for us to style and manipulate logs in the most appropriate way based on terminal size (or other properties).

Additional context
This feature will require providers to update their logging strategy as well. Because of this, it's important that our logger library is well structured.

@Tpuljak Tpuljak added the enhancement New feature or request label May 21, 2024
@Tpuljak Tpuljak self-assigned this May 21, 2024
@idagelic idagelic assigned idagelic and unassigned Tpuljak May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants