fix: duplicate repo entry frontend validation #580
Conversation
Signed-off-by: Ezhil Shanmugham <ezhil930@gmail.com>
There was a problem hiding this comment.
@ezhil56x thanks for the PR!
The user should be let know there are duplicate repo entries before having submitted the form
This quote from the issue was hinting more towards not breaking the command if the UI detects a duplicate repo entry.
We should just notify the user via an error message in the UI that we detected a duplicate entry and that the user should provide a different repo.
Note: This should be achieved in both --manual mode and TUI mode. --manual mode is that you recorded, it's also automatically triggered if the user does not have a git provider set. I suggest you add a git provider with daytona git-provider add and then test both daytona create --multi-project and daytona create --multi-project --manual.
I'll convert this PR to draft. When you're done, mark it as ready for review and we'll take a look again. Thanks!
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Duplicate repo entry frontend validation
Description
Adding the same repo twice in a multi project workspace will do frontend validation
Closes #550
/claim #550
Related Issue(s)
This PR addresses issue #550
Screenshots
2024-05-18.01-04-16.mp4