Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daytona server target remove - removing target leaves workspaces in the list #423

Closed
nkkko opened this issue Apr 22, 2024 · 11 comments
Closed
Labels
bug Something isn't working never stale An issue that never goes stale

Comments

@nkkko
Copy link
Member

nkkko commented Apr 22, 2024

Describe the bug
When using the daytona server target remove command to remove a target, the command successfully removes the target but leaves the associated workspaces in the list. This prevents users from easily removing those workspaces later.

To Reproduce
Steps to reproduce the behavior:

  1. Use the daytona server target remove command to remove a target.
  2. Check the list of workspaces.
  3. Try to interact with workspace created on the removed target.

Expected behavior
After removing a target, the associated workspaces should also be removed from the list, allowing users to easily manage their workspace configurations. Also user should be alerted that removing the target will impact management of the workspaces.

Additional context
This issue can lead to clutter in the workspace list and confusion for users trying to clean up their configurations.

@nkkko nkkko added the bug Something isn't working label Apr 22, 2024
@nkkko
Copy link
Member Author

nkkko commented Apr 23, 2024

maybe we could even have something like daytona rm -f workspace_name

@Tpuljak Tpuljak added the never stale An issue that never goes stale label Apr 30, 2024
@Tpuljak
Copy link
Member

Tpuljak commented Apr 30, 2024

I suggest the following:

  1. When removing a target, if workspaces with that target exist, alert the user that we recommend deleting the workspaces and ask the user if they want us to do it (e.g. It is recommended to delete workspaces associated with this target. Do you want to delete them? Yes/No)
  2. If the user decides to leave the workspaces alive, the problem is a bit more complex. Because the target no longer exists, the associated provider can not delete (or do anything for that matter) these workspaces. They are essentially orphaned. The user can work in them, but can not do anything else. I suggest that, when deleting a workspace, we alert the user that the provider target is missing and inform them that deleting the workspace won't delete resources associated with the workspace but simply remove it from the Daytona server "database".

@opiredev
Copy link

opiredev commented May 1, 2024

@nabby27 created a $50.00 reward using Opire

How to earn this reward?

Since this project does not have Opire bot installed yet 😞 you need to go to Opire and claim the rewards through your programmer's dashboard once you have your PR ready 💪

@Tpuljak
Copy link
Member

Tpuljak commented May 1, 2024

@nabby27 created a $50.00 reward using Opire

How to earn this reward?

Since this project does not have Opire bot installed yet 😞 you need to go to Opire and claim the rewards through your programmer's dashboard once you have your PR ready 💪

@nabby27 can you explain a bit what's going on here and how it's relevant to Daytona?

@nabby27
Copy link

nabby27 commented May 1, 2024

Hi @Tpuljak, I just want to encourage this issue to be resolved soon with a $50 reward. Is there something wrong with it?

@Tpuljak
Copy link
Member

Tpuljak commented May 1, 2024

Hi @Tpuljak, I just want to encourage this issue to be resolved soon with a $50 reward. Is there something wrong with it?

Nothing wrong, of course 😄

Thanks for that!

@mobley-trent
Copy link
Contributor

/try #423

@opiredev
Copy link

🔥 The user @mobley-trent has claimed all rewards for this issue using Opire.
🎯 You can see the PR here
💰 @nabby27 you can pay the related rewards here

@mobley-trent
Copy link
Contributor

@nabby27 I would like to know how to claim the bounty

@nabby27
Copy link

nabby27 commented May 28, 2024

Hi @mobley-trent, I have just made the payment! Thank you for your contribution to Daytona and I hope you like it Opire ✌️

@Tpuljak
Copy link
Member

Tpuljak commented Jun 3, 2024

Closing this since #599 was merged. Forcing workspace removal will be done with #576.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale An issue that never goes stale
Projects
None yet
Development

No branches or pull requests

5 participants