Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This took me a while to figure out but basically with this tiny modification, any attachment (images primarily) can be used as inline images within the HTML email like:
This will only work if the image files are in the root directory (as I'm parsing out all parent folders from the path) but in that case it works like a charm, and even Gmail likes it and displays the image automatically within the body of the email at the designated location as opposed to just having the image be at bottom like some random attachment..
I thought this is quite a big improvement..