Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API calls can be reduced by setting workflow conclusion #223

Open
sidx1024 opened this issue Feb 7, 2023 · 2 comments
Open

API calls can be reduced by setting workflow conclusion #223

sidx1024 opened this issue Feb 7, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@sidx1024
Copy link

sidx1024 commented Feb 7, 2023

The workflow conclusion/status check is inside the for-loop.

Since the workflow status can is an acceptable parameter in list workflow runs API, the pagination can be reduced.
Screenshot 2023-02-07 at 2 21 03 PM

@dawidd6
Copy link
Owner

dawidd6 commented Aug 11, 2023

It was done like that until some weirdness with API results popped up. See #95. Maybe we could revert that now?

@dawidd6 dawidd6 added the help wanted Extra attention is needed label Aug 11, 2023
@KenticoDevTrev
Copy link

I ran into this where it's hitting our Artifact API call limits now... so looks like this is the culprit.

Any possibility an update can be made to use the artifact name api to simply grab the artifact by the given "name" if searchArtifacts is true?

I'm not great at Github CLI nor what you have all coded in to do a fork and pull...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants