Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to appropriate listWorkflowRunArtifacts call #205

Conversation

robbie-unlikelyai
Copy link
Contributor

I have to admit, I'm not really familiar with any of this code - I copied this from a bit further down the file as it seemed to do what was needed. I'm also not really sure what testing needs to be done etc.

More detail is in the issue #204

@dawidd6 dawidd6 merged commit b12b127 into dawidd6:master Nov 9, 2022
@robbie-unlikelyai robbie-unlikelyai deleted the handle-search-artifacts-with-many-artifacts branch November 9, 2022 09:24
@jamesmortensen
Copy link
Contributor

Hi @robbie-unlikelyai it looks like adding pagination has broken some workflows. We're getting Cannot read properties of undefined (reading 'artifacts'). From what I can tell, the code looks like it should work, but it seems to be returning undefined. Were you able to see it working on your end? There's an issue open here: #207.

We just downgraded to 2.24.0 and reran our workflow manually for now.

@robbie-unlikelyai
Copy link
Contributor Author

Hey @jamesmortensen - ah that's annoying, sorry! I'm relatively new to GH actions and so hadn't actually tested this end-to-end when I raised the PR. To be honest, I wasn't sure how - I mostly raised this PR as a starting point because I thought the code looked like it should work.

@dawidd6 - perhaps this code should be reverted and a new release made to fix the fact things are broken. We could then have another go at getting this fix in without the bug?

@dawidd6
Copy link
Owner

dawidd6 commented Nov 9, 2022

Reverted for now.

We can have another go, yep.

@jamesmortensen
Copy link
Contributor

@robbie-unlikelyai to test it, you could create a workflow that uploads multiple artifacts greater than 30, and then run a workflow immediately after that to call the action-download-artifact.

In .github/workflows you can see some examples of some tests that are there so far.

@robbie-unlikelyai
Copy link
Contributor Author

Thanks @jamesmortensen - a new attempt at this is now in place at #225. Sorry it's taken so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants