Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle search_artifacts: true when workflow has many artifacts #204

Open
robbie-unlikelyai opened this issue Nov 8, 2022 · 2 comments
Open

Comments

@robbie-unlikelyai
Copy link
Contributor

Currently, if a workflow produces more than 30 artifacts, then using the search_artifacts option breaks this action. The reason for this is that the call at https://github.com/dawidd6/action-download-artifact/blob/master/main.js#L125 does not handle pagination, and the default page size is 30 (see here). Therefore, if there are e.g. 31 artifacts and you are searching for the last one, the artifact isn't retrieved by the listWorkflowRunArtifacts call and the artifact therefore isn't found. The solution to this is to add pagination handling to this call.

@robbie-unlikelyai
Copy link
Contributor Author

PR to try and fix this: #205, though worth noting that I'm not really familiar with any of this code - I just thought there might be a quick fix for this based on some of the other code I could see.

@robbie-unlikelyai
Copy link
Contributor Author

Second attempt to try and fix this, after first attempt had to be reverted: #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant