Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core.getBooleanInput(), fixes #179 #197

Merged
merged 2 commits into from Oct 8, 2022
Merged

Use core.getBooleanInput(), fixes #179 #197

merged 2 commits into from Oct 8, 2022

Conversation

ping
Copy link
Contributor

@ping ping commented Oct 8, 2022

Attempt to fix #179 based on the suggestion in the issue to use core.getBooleanInput() for bool inputs.

@ping
Copy link
Contributor Author

ping commented Oct 8, 2022

No idea how to fix the failed CI, or if it is even related to this change
https://github.com/dawidd6/action-download-artifact/actions/runs/3208871439/jobs/5245126819

@dawidd6
Copy link
Owner

dawidd6 commented Oct 8, 2022

Yes. Thanks.

@dawidd6 dawidd6 merged commit c49ff0c into dawidd6:master Oct 8, 2022
@ping ping deleted the fix-179 branch October 8, 2022 12:19
dawidd6 pushed a commit that referenced this pull request Oct 15, 2022
* Use core.getBooleanInput(), fixes #179

* Also update input definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean inputs aren't handled as booleans
2 participants