Add fallbackToDownoadAction #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidd6
reviewed
Sep 28, 2022
dawidd6
reviewed
Sep 28, 2022
|
Dawid, if I misread the meaning of check_artifacts just let me know; i will create another flag, or another flag value for that |
|
Another input would be much nicer. |
|
Hey Dawid, I've simplified PR to be a "fallback only". I've also removed one of three tests. check_artifacts is no longer altered. Could you please take a look? @dawidd6 |
|
Thanks, additionally made some cosmetical changes only. |
|
This change broke CI on master: https://github.com/dawidd6/action-download-artifact/actions/runs/3170303976 Reverting... |
|
...and it remains broken after reverting, interesting. |
|
Actually something else broke, reverted second time, so it stays merged 😄 |
|
@dawidd6 thank you for merging and for the great and very useful action |
dawidd6
added a commit
that referenced
this pull request
Oct 15, 2022
* Add fallback to downloadAction * Fix review comments * Update main.js Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dawid,
This is PR for #173
The only notable changes are in
main.js, a behavior changes if workflow_conclusion is 'in_progress' or emptyIt has some limitations, e.g. no control over unpacking, search_artifacts is ignored when checking the current build
This is my first attempt in modern js, feel free outline if there are any style errors or other errors