feat: add additional input to define how to fail the action #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidd6
requested changes
Aug 19, 2022
benkane
reviewed
Aug 29, 2022
dawidd6
reviewed
Aug 30, 2022
| # Optional, choose how to exit the action if no artifact is found | ||
| # can be one of: | ||
| # "fail", "warn", "ignore" | ||
| # default ignore |
There was a problem hiding this comment.
Suggested change
| # default ignore | |
| # default: "fail" |
😄
| if_no_artifact_found: | ||
| required: false | ||
| description: choose how to exit the action if no artifact is found | ||
| default: "fail" |
There was a problem hiding this comment.
Suggested change
| default: "fail" | |
| default: fail |
Comment on lines
+144
to
+145
| setExitMessage(ifNoArtifactFound, "no matching workflow run found with any artifacts?") | ||
| return |
There was a problem hiding this comment.
Suggested change
| setExitMessage(ifNoArtifactFound, "no matching workflow run found with any artifacts?") | |
| return | |
| return exitWithMessage(ifNoArtifactFound, "no matching workflow run found with any artifacts?") |
Could we do it like this?
| for (const artifact of artifacts) { | ||
|
|
|
Imma go ahead and merge this, will do some adjustments later. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an additional input
if_no_files_foundwhich follows the semantic ofupload-artifact.the proposes solution in the issue comments to use
continue-on-errorhas the ugly side-effect of showing a red warning in the workflow summary.as I'm trying to train the developers to actually look at this summary in order to watch out for lint warning, they should not see red false-negative results in this list.