Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean inputs aren't handled as booleans #179

Closed
amezin opened this issue Jul 26, 2022 · 2 comments · Fixed by #197
Closed

Boolean inputs aren't handled as booleans #179

amezin opened this issue Jul 26, 2022 · 2 comments · Fixed by #197
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amezin
Copy link
Contributor

amezin commented Jul 26, 2022

Currently, if you pass false to any of the "boolean" inputs, it will be treated as true. Because getInput() returns a string, and Boolean("false") evaluates to true.

Newer actions toolkit has core.getBooleanInput(). For it, #166 needs to be merged (with corresponding updates to the bundled node_modules).
@amezin amezin mentioned this issue Jul 26, 2022
Merged
@dawidd6
Copy link
Owner

dawidd6 commented Aug 30, 2022

Could you submit a PR for that? I agree current behavior isn't what we want.

@dawidd6 dawidd6 added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 30, 2022
@amezin
Copy link
Contributor Author

amezin commented Aug 30, 2022

I'm not using this action anymore (got rid of cross-workflow artifact passing). And, unfortunately, I don't have the time to fix things I'm not using. From the description, it should be obvious what to fix and how.

@ping ping mentioned this issue Oct 8, 2022
Merged
dawidd6 pushed a commit that referenced this issue Oct 8, 2022
@ping
Use core.getBooleanInput(), fixes #179 (#197)
c49ff0c 
* Use core.getBooleanInput(), fixes #179

* Also update input definitions
dawidd6 pushed a commit that referenced this issue Oct 15, 2022
@ping @dawidd6
Use core.getBooleanInput(), fixes #179 (#197)
525d1e5 
* Use core.getBooleanInput(), fixes #179

* Also update input definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use core.getBooleanInput(), fixes #179
2 participants
@amezin @dawidd6