Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write zip file in path #169

Merged
merged 1 commit into from Jun 19, 2022
Merged

write zip file in path #169

merged 1 commit into from Jun 19, 2022

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Jun 18, 2022

Now if we check unpacking, the zip file will be written according to the path specified, and not in the current folder
Fixes #168

main.js Outdated Show resolved Hide resolved
@iTrooz
Copy link
Contributor Author

iTrooz commented Jun 19, 2022

I undid my refactoring since you didn't want to use the dir/basePath variable

@iTrooz
Copy link
Contributor Author

iTrooz commented Jun 19, 2022

Hum.. Okay, i'll stop messing with the CI here and do it on my fork, I'll commit when the code is fixed

@iTrooz
Copy link
Contributor Author

iTrooz commented Jun 19, 2022

All done !

Copy link
Owner

@dawidd6 dawidd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@dawidd6 dawidd6 merged commit 6765a42 into dawidd6:master Jun 19, 2022
gabriel-samfira pushed a commit to gabriel-samfira/action-download-artifact that referenced this pull request Jul 8, 2022
gabriel-samfira pushed a commit to gabriel-samfira/action-download-artifact that referenced this pull request Jul 8, 2022
gabriel-samfira pushed a commit to gabriel-samfira/action-download-artifact that referenced this pull request Jul 8, 2022
gabriel-samfira pushed a commit to gabriel-samfira/action-download-artifact that referenced this pull request Jul 8, 2022
gabriel-samfira pushed a commit to gabriel-samfira/action-download-artifact that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'path' key with 'skip_unpack'
2 participants