generated from actions/container-action
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write zip file in path #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidd6
reviewed
Jun 19, 2022
I undid my refactoring since you didn't want to use the dir/basePath variable |
Hum.. Okay, i'll stop messing with the CI here and do it on my fork, I'll commit when the code is fixed |
All done ! |
dawidd6
approved these changes
Jun 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks.
gabriel-samfira
pushed a commit
to gabriel-samfira/action-download-artifact
that referenced
this pull request
Jul 8, 2022
gabriel-samfira
pushed a commit
to gabriel-samfira/action-download-artifact
that referenced
this pull request
Jul 8, 2022
gabriel-samfira
pushed a commit
to gabriel-samfira/action-download-artifact
that referenced
this pull request
Jul 8, 2022
gabriel-samfira
pushed a commit
to gabriel-samfira/action-download-artifact
that referenced
this pull request
Jul 8, 2022
gabriel-samfira
pushed a commit
to gabriel-samfira/action-download-artifact
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if we check unpacking, the zip file will be written according to the path specified, and not in the current folder
Fixes #168