Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which parameters will require pagination to avoid rate limiting #164

Open
sidx1024 opened this issue Jun 7, 2022 · 3 comments
Open
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sidx1024
Copy link

sidx1024 commented Jun 7, 2022

We've seen quite a few times that we're rate limited by GitHub due to multiple API calls. This happens in cases where we have to paginate across results for listWorkflowRuns request.

Example

Usage A.

  workflow: 'my-workflow.yml'
  workflow_conclusion: success
  commit: ${{ github.event.pull_request.base.sha }}

Usage B.

  workflow: 'my-workflow.yml'
  workflow_conclusion: success
  branch: ${{ github.event.pull_request.base.ref }}

Here, the usage B will be more efficient as branch is an accepted parameter for listWorkflowRuns request.

@dawidd6 dawidd6 added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 30, 2022
@adam-mrozik
Copy link

Just FYI, happens to me as well and I am using branch, not commit. But, I am using "search_artifacts" option

@lukasz-mitka
Copy link
Contributor

lukasz-mitka commented Feb 21, 2023

Actually commit: version could be vastly improved by using listWorkflowRuns with head_sha parameter.
#226

@lukasz-mitka
Copy link
Contributor

@sidx1024 #227 has been merged and released.
commit should no longer trigger so many API calls.

Just an FYI since documentation could still be useful for other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants