Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input option to unpack (or not) downloaded artifact(s) #150

Merged
merged 18 commits into from Apr 16, 2022

Conversation

daleyjem
Copy link
Contributor

@daleyjem daleyjem commented Apr 15, 2022

Adds an optional skip_unpack input option (default: false), so that user can bypass unzipping the downloaded artifacts.

Also... While my first instinct is to npm i a Node package, it added quite a bit to node_modules and package-lock.json, so I reverted that to keep the PR small.

@dawidd6
Copy link
Owner

dawidd6 commented Apr 15, 2022

Can we have this input inverted? For example rename it to skip_unpack, default to false and not use this new function to get boolean value?

@daleyjem
Copy link
Contributor Author

Can we have this input inverted? For example rename it to skip_unpack, default to false and not use this new function to get boolean value?

Like that?

@daleyjem daleyjem marked this pull request as draft April 16, 2022 02:52
@daleyjem
Copy link
Contributor Author

Lemme see if I can get my tests passing now that workflow filtering seems to be working again, and then I'll take it out of draft

@daleyjem daleyjem marked this pull request as ready for review April 16, 2022 04:32
@daleyjem
Copy link
Contributor Author

@dawidd6 Ok... I think it's ready now.

@dawidd6 dawidd6 merged commit b2abf17 into dawidd6:master Apr 16, 2022
@dawidd6
Copy link
Owner

dawidd6 commented Apr 16, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants