Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search capability #122

Merged
merged 11 commits into from Nov 23, 2021
Merged

Search capability #122

merged 11 commits into from Nov 23, 2021

Conversation

martcus
Copy link
Contributor

@martcus martcus commented Nov 19, 2021

For those who need to find a certain artifact knowing only its name.

@martcus
Copy link
Contributor Author

martcus commented Nov 19, 2021

my apologies, now all checks have passed

@dawidd6 dawidd6 self-assigned this Nov 19, 2021
@fs24-chrter
Copy link

That's a nice addition 👍

@Schuchie
Copy link

This is the missing changes, which would help me significantly! Thx for sharing! :)

@Schuchie
Copy link

Schuchie commented Nov 22, 2021

@dawidd6 check_artifacts did not work on my pipeline. It did not found the artifact which was created by an older run.

Edit: I saw the PR from https://github.com/dawidd6/action-download-artifact/pull/88/files : I think they only download the artifact from the latest Workflow, but not older ones. Thats why this change is different.

@martcus
Copy link
Contributor Author

martcus commented Nov 22, 2021

This change allows you to identify and download an artifact based on its name (useful when, for example, you store artifacts with the version name).

from my analysis, the check_artifacts downloads the latest available artifact.

@dawidd6
Copy link
Owner

dawidd6 commented Nov 22, 2021

Change the input to be a boolean, we already have name input.

@martcus
Copy link
Contributor Author

martcus commented Nov 23, 2021

Changed. Thanks

Copy link
Owner

@dawidd6 dawidd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the logic a bit. Thanks.

@dawidd6 dawidd6 merged commit 09385b7 into dawidd6:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants