Require Set (from stdlib) #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the bug report and fix, @sbrinkhorst!
I wonder how to catch something like this in the future, since the test dependencies must be requiring set somewhere.
lib/json_schemer/schema/base.rb
Outdated
| @@ -1,4 +1,6 @@ | |||
| # frozen_string_literal: true | |||
| require 'set' | |||
There was a problem hiding this comment.
For consistency, I think this should be with the other stdlib require statements here:
json_schemer/lib/json_schemer.rb
Lines 2 to 8 in ab5ea07
There was a problem hiding this comment.
That makes sense, I've moved it.
I have no ideas about how to test this either. I don't even understand why it suddenly became a problem for us while we had no code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #98