Build as OSGI bundle #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoten
reviewed
Jun 8, 2020
| <extensions>true</extensions> | ||
| <configuration> | ||
| <obrRepository>NONE</obrRepository> | ||
| <instructions> |
There was a problem hiding this comment.
empty instructions? Just leave out?
|
thanks, can you rebase so that travis runs please. |
|
don't worry about the review stuff, I'll do the merge and look at it myself now. |
|
I removed the empty config block and released guava-mini to Maven Central as 0.1.3. I'll update in odata-client shortly. |
Sorry about the delayed response - was in meetings all morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my pull request for odata-client, this commit adds the OSGI metadata to the package manifest to aid deployment into OSGI environments.
Assuming you're happy with this, I'd like to bump the dependency in odata-client as well as removing the dependency on jcip-annotations which appears to be unused. Once all this is done, odata-client and all its dependencies will be OSGI-friendly.