Updates to the release process #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
update_releasing
branch
from
3f0044b
to
70f18f0
Compare
pganssle
commented
Nov 2, 2019
tox.ini
Outdated
| commands = python release.py | ||
| commands = | ||
| python release.py build | ||
| python release.py sign |
There was a problem hiding this comment.
Probably we should make this conditional on gpg being installed with a default key set or something, because I just realized that this probably will (or at least should) fail on Travis.
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 2, 2019
pganssle
force-pushed
the
update_releasing
branch
2 times, most recently
from
4ec3d1f
to
4326667
Compare
pganssle
force-pushed
the
update_releasing
branch
from
4326667
to
b58e321
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 2, 2019
pganssle
force-pushed
the
update_releasing
branch
from
b58e321
to
25f9c5e
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 2, 2019
pganssle
force-pushed
the
update_releasing
branch
from
25f9c5e
to
042d8c0
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 2, 2019
pganssle
force-pushed
the
update_releasing
branch
from
042d8c0
to
ea321aa
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 2, 2019
pganssle
force-pushed
the
update_releasing
branch
from
7ce3d54
to
1804b15
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 3, 2019
pganssle
force-pushed
the
update_releasing
branch
from
1804b15
to
d5d4239
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 3, 2019
pganssle
force-pushed
the
update_releasing
branch
from
d5d4239
to
a44d1ee
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 3, 2019
pganssle
force-pushed
the
update_releasing
branch
from
a44d1ee
to
29ff7c8
Compare
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Nov 3, 2019
pganssle
force-pushed
the
update_releasing
branch
from
29ff7c8
to
17efe46
Compare
The build environment was originally broken, and no release environment existed. This allows for the Python dependencies for `release.py` to be satisfied automatically as part of invoking the tox command.
The orignal test was using `[ ! -e "dist/*.whl" ]` to try and detect that a wheel was created (and an analogous command for the tarball), but it turns out that this would succeed even if the build command completely fails! The reason is that the shellw as expanding "dist/*.whl" to an empty list, which the conditional took to mean that it didn't need to check for the existence of *any* files. This was replaced by a more robust command that checks that exactly one of each file was created by the build.
Moving to a model where dependencies are provided by `tox` as needed where possible.
Many of these miscellaneous items would actually be interesting to downstream consumers, even though they are not "bugfixes" (e.g. changes to the test suite or package metadata). Rather than ask contributors to decide whether their contribution meets this standard, we'll instead manually curate which PRs are "hidden" in the changelog.
pganssle
force-pushed
the
update_releasing
branch
from
17efe46
to
e0f0b7e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The
RELEASINGdocument had gotten quite out of sync with the actual release procedure, so I have updated it.I have also added new
toxenvironments to handle the creation of virtual environments for some of the tasks around building and releasing.Pull Request Checklist