Fix typo in setup.cfg warning configuration #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
It appears that we were relying on the "errors" filter to treat PendingDeprecationWarning as an error due to a typo in setup.cfg. This line is apparently redundant with the "error" line anyway, but it's best to have a working version of it if we're going to have it at all. I am leaving it in place to be explicit that even these "ignored by default" warnings should be errors, in case a default changes later.
pganssle
force-pushed
the
pending_deprecation_warning
branch
from
d832c3e
to
8f506ba
Compare
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
It appears that we were relying on the "errors" filter to treat PendingDeprecationWarning as an error due to a typo in setup.cfg. This line is apparently redundant with the "error" line anyway, but it's best to have a working version of it if we're going to have it at all. I am leaving it in place to be explicit that even these "ignored by default" warnings should be errors, in case a default changes later.
Pull Request Checklist