Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage in test_isoparser #879

Merged
merged 2 commits into from Feb 24, 2019

Conversation

fhuang5
Copy link
Contributor

@fhuang5 fhuang5 commented Feb 23, 2019

Summary of changes

  1. added #pragma: no cover to the if and def lines not tested on Python 2 and 3
  2. Change the time_val to tstr in if isinstance to hit in test_isoparser

Closes #776

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

There is one bug here in the tests, which was detected when we saw that
the coverage on the test files was less than 100%. This fixes the bug
and also uses nocover pragmas for known-uncovered parts of the tests, so
that the baseline is 100%.
pganssle pushed a commit to fhuang5/dateutil that referenced this pull request Feb 24, 2019
@pganssle pganssle changed the title improve coverage for tests of test_isoparser Improve coverage in test_isoparser Feb 24, 2019
@pganssle pganssle merged commit 222795d into dateutil:master Feb 24, 2019
@pganssle pganssle mentioned this pull request Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants